Skip to content

ref(ui): Drop unused optional args in issueDetails and seer workflows - #123222

Merged
scttcper merged 3 commits into
getsentry:masterfrom
JonasBa:jonas/unused-args/views
Sep 1, 2026
Merged

ref(ui): Drop unused optional args in issueDetails and seer workflows#123222
scttcper merged 3 commits into
getsentry:masterfrom
JonasBa:jonas/unused-args/views

Conversation

@JonasBa

@JonasBa JonasBa commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Split out of #122373 and #122624 so this folder can be reviewed on its own (~197 LOC).

Summary

  • Remove unused optional arguments and fields under static/app/views.
  • Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults.

Files

  • static/app/views/alerts/wizard/utils.tsx
  • static/app/views/autofixIssuesDemo/useAutofixIssues.tsx
  • static/app/views/issueDetails/groupFeatureFlags/hooks/useGroupFeatureFlags.tsx
  • static/app/views/issueDetails/sidebar/seerDrawer.tsx
  • static/app/views/issueDetails/useAssignIssueMutation.ts
  • static/app/views/issueDetails/utils.tsx
  • static/app/views/navigation/primary/whatsNew.tsx
  • static/app/views/navigation/secondary/sections/issues/issueViews/useUpdateGroupSearchViewLastVisited.tsx
  • static/app/views/preprod/snapshots/main/snapshotDiffBodies.tsx
  • static/app/views/preprod/utils/releasesUrl.ts
  • static/app/views/seerWorkflows/overview/overviewIssueAssignee.spec.tsx
  • static/app/views/seerWorkflows/overview/overviewIssueAssignee.tsx
  • static/app/views/seerWorkflows/overview/useIsInView.ts

Test plan

  • CI typecheck / frontend tests for this slice.
  • Spot-check call sites in static/app/views.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@JonasBa
JonasBa requested review from a team as code owners August 31, 2026 20:39
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 31, 2026
@scttcper

Copy link
Copy Markdown
Member

thanks for including a list of files in the pr description, never would've figured it out otherwise

Jonas Badalic and others added 2 commits August 31, 2026 21:36
Co-authored-by: Cursor <cursoragent@cursor.com>
The overview page still batches project members once and passes that list down so each card does not refetch. Dropping the prop made AssigneeSelector fetch per card and broke the batching test.

Co-authored-by: Cursor <cursoragent@cursor.com>
@scttcper scttcper added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Sep 1, 2026
@scttcper
scttcper merged commit ffba2ea into getsentry:master Sep 1, 2026
80 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants