refs(incidents): Remove IncidentSuspectCommit model - #16781
Merged
Conversation
wedamija
force-pushed
the
danf/remove_supect_commits
branch
from
February 3, 2020 22:46
77095ee to
2a2c36f
Compare
wedamija
added a commit
that referenced
this pull request
Feb 4, 2020
Final step in removing this table, can only be merged after #16781 has deployed. Migration: ``` BEGIN; -- -- Custom state/database change combination -- DROP TABLE "sentry_incidentsuspectcommit"; ; COMMIT; ```
markstory
approved these changes
Feb 4, 2020
wedamija
force-pushed
the
danf/remove_supect_commits
branch
from
February 7, 2020 19:02
2a2c36f to
0553612
Compare
Follow-up to #16758. This removes the model without actually removing the table from the databse. We'll remove the table in a final follow-up pr.
wedamija
force-pushed
the
danf/remove_supect_commits
branch
from
February 13, 2020 23:22
0553612 to
d76c6b8
Compare
markstory
approved these changes
Feb 14, 2020
wedamija
added a commit
that referenced
this pull request
Feb 14, 2020
Final step in removing this table, can only be merged after #16781 has deployed. Migration: ``` BEGIN; -- -- Custom state/database change combination -- DROP TABLE "sentry_incidentsuspectcommit"; ; COMMIT; ```
wedamija
added a commit
that referenced
this pull request
Feb 14, 2020
Final step in removing this table, can only be merged after #16781 has deployed. Migration: ``` BEGIN; -- -- Custom state/database change combination -- DROP TABLE "sentry_incidentsuspectcommit"; ; COMMIT; ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16758. This removes the model without
actually removing the table from the databse. We'll remove the table in a final follow-up pr.
Migration sql, no changes as expected: