fix(ui): Move /auth/login/ outside of views/app route#18994
Merged
Conversation
billyvg
commented
May 22, 2020
Comment on lines
20
to
21
Member
Author
There was a problem hiding this comment.
Moving these up to encompass unauthed parts of the app since they depend on emotion.
billyvg
force-pushed
the
fix/ui/move-route-auth-login-exp-spa
branch
from
26bee90 to
6fdf543
Compare
evanpurkhiser
approved these changes
May 22, 2020
scttcper
approved these changes
May 26, 2020
This moves our experimental `/auth/login/` route outside of `views/app`. `views/app` expects the user to already be logged in. This fixes an issue where when you login via experimental SPA, you do not have a list of organizations to choose from since the request was made when you were logged out in the login screen.
billyvg
force-pushed
the
fix/ui/move-route-auth-login-exp-spa
branch
from
655ed78 to
d95882c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves our experimental
/auth/login/route outside ofviews/app.views/appexpects the user to already be logged in. This fixes an issue where when you login via experimental SPA, you do not have a list of organizations to choose from since the request was made when you were logged out in the login screen.