fix(ui): fixed sidenav active state #19875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This secondary sidenav bar is pretty complex. We want it to be sticky when scrolling the main content area, but also let you scroll within the menu itself when the browser window cuts off the items. In my previous change I didn’t take into consideration that the scroll overflow would cut off the active state, so I’m fixing that here by moving the padding from the outer nav to the sticky positioned component.
Before
After