Skip to content

Conversation

@robinrendle
Copy link
Contributor

@robinrendle robinrendle commented Jul 14, 2020

This secondary sidenav bar is pretty complex. We want it to be sticky when scrolling the main content area, but also let you scroll within the menu itself when the browser window cuts off the items. In my previous change I didn’t take into consideration that the scroll overflow would cut off the active state, so I’m fixing that here by moving the padding from the outer nav to the sticky positioned component.

Before

Screen Shot 2020-07-14 at 4 37 50 PM

After

Screen Shot 2020-07-14 at 4 36 37 PM

Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix

@robinrendle robinrendle merged commit 23795f2 into master Jul 15, 2020
@robinrendle robinrendle deleted the rr/fixed-sidenav branch July 15, 2020 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants