build(ci): Trigger getsentry backend tests on deps change#23642
Merged
build(ci): Trigger getsentry backend tests on deps change#23642
Conversation
billyvg
force-pushed
the
build/ci/test-backend-getsentry-test
branch
from
5747fc2 to
fa3a0dd
Compare
… trigger getsentry dispatch only when requirements.txt changes
…uest so we can test)
… link reference itself
billyvg
force-pushed
the
build/ci/test-backend-getsentry-test
branch
from
81b72b6 to
b99005a
Compare
billyvg
commented
Feb 9, 2021
Comment on lines
+32
to
+33
| backend_dependencies: &backend_dependencies | ||
| - 'requirements-*.txt' |
Member
Author
There was a problem hiding this comment.
This is what we'll use to determine if a dispatch to getsentry is required.
Member
There was a problem hiding this comment.
You should probably add that as a comment.
| # | ||
| # See https://github.com/getsentry/sentry/pull/21600 for more details | ||
| # TODO: this needs to be pull_request_target | ||
| pull_request: |
Member
Author
There was a problem hiding this comment.
this is pull_request for testing
| owner: 'getsentry', | ||
| repo: 'getsentry', | ||
| workflow_id: workflow, | ||
| ref: 'build/ci/add-backend-dependencies-test', // TODO: this needs to be 'master' |
Member
Author
There was a problem hiding this comment.
This is for testing only.
Member
Author
|
You can view it working here: https://github.com/getsentry/getsentry/runs/1859931351?check_suite_focus=true (And javascript still works as expected as well https://github.com/getsentry/getsentry/actions/runs/549994891) |
billyvg
changed the title
evanpurkhiser
approved these changes
Feb 9, 2021
joshuarli
approved these changes
Feb 9, 2021
Contributor
size-limit report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will trigger getsentry backend test when
requirements*.txtchanges. This functions similarly to the getsentry javascript test.
The failed check will show you a message w/ instructions on how to proceed:
