Skip to content

Comments

security: Upgrade to Python 3.6.13#23969

Merged
joshuarli merged 5 commits intomasterfrom
evanpurkhiser/refpy3-upgrade-to-3613
Mar 1, 2021
Merged

security: Upgrade to Python 3.6.13#23969
joshuarli merged 5 commits intomasterfrom
evanpurkhiser/refpy3-upgrade-to-3613

Conversation

@evanpurkhiser
Copy link
Member

Upgrading for security patches

Upgrading for security patches
@BYK
Copy link
Member

BYK commented Feb 19, 2021

Should we pin the patch version in our Docker files too:

FROM python:3.6-slim-buster
?

@joshuarli
Copy link
Member

Should we pin the patch version in our Docker files too:

FROM python:3.6-slim-buster

?

Yeah, that'd be preferable.

@joshuarli joshuarli self-assigned this Feb 25, 2021
@joshuarli
Copy link
Member

So uhh, I think this failing test case is just not right.

_______________________________________________________ BuildIncidentAttachmentTest.test_parse_link ________________________________________________________
tests/sentry/integrations/slack/test_utils.py:331: in test_parse_link
    assert (
E   AssertionError: assert 'organization...esolved%27%5D' == 'organizations...esolved%27%5D'
E     Skipping 59 identical leading characters in diff, use -v to show
E     - roject%7D&amp%3Bquery=%5B%27is%3Aunresolved%27%5D
E     ?           ------
E     + roject%7D&query=%5B%27is%3Aunresolved%27%5D

& is an html or xml encoding. URL encoding would be %26 if you wanted a literal ampersand and not a query parameter.

@evanpurkhiser
Copy link
Member Author

You're right. Just change it

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner February 26, 2021 01:00
@joshuarli joshuarli changed the title ref(py3): Upgrade to 3.6.13 security: Upgrade to Python 3.6.13 Feb 26, 2021
@evanpurkhiser
Copy link
Member Author

Approved

Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing an audit (ag 3\\.6) turned up is mypy.ini. That doesn't want a patch version, right?

@joshuarli joshuarli merged commit 68fc7c1 into master Mar 1, 2021
@joshuarli joshuarli deleted the evanpurkhiser/refpy3-upgrade-to-3613 branch March 1, 2021 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants