build(chartcuterie): Simplify webpack config#24455
Merged
evanpurkhiser merged 1 commit intomasterfrom Mar 15, 2021
Merged
Conversation
scefali
reviewed
Mar 15, 2021
| }, | ||
|
|
||
| devtool: 'none', | ||
| optimization: {minimize: false}, |
Contributor
There was a problem hiding this comment.
@evanpurkhiser do we have minimization enabled for production builds somewhere else?
Member
Author
There was a problem hiding this comment.
We don't really need to minify the chartcuterie configuration module.
I'll make that more clear in the PR description
scefali
approved these changes
Mar 15, 2021
evanpurkhiser
deleted the
evanpurkhiser/buildchartcuterie-simplify-webpack-config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids extending the sentry webpack config, and instead just pulls in specific configuration from the sentry webpack config,