Skip to content

feat(sidebar): Add link to marketing homepage inside product#25684

Merged
chadwhitacre merged 1 commit intomasterfrom
cwlw/link-to-marketing
May 4, 2021
Merged

feat(sidebar): Add link to marketing homepage inside product#25684
chadwhitacre merged 1 commit intomasterfrom
cwlw/link-to-marketing

Conversation

@chadwhitacre
Copy link
Copy Markdown
Member

@chadwhitacre chadwhitacre commented Apr 27, 2021

Closes #25670.

@ckj This implements your first suggestion (from private Slack):

I can think of two paths forward at this point 1) add a link to the user/org dropdown. 'Visit Sentry.io' or 2) add a link to the footer saying the same

The footer felt way too distant. Lots of scrolling to discover that there are even links down there (does anyone ever click on those? genuinely interested). Also, "Visit Sentry.io" felt weird because the user is already on https://sentry.io/. 🙈

Choice of "Homepage" and "Pricing" is based on @chriswiggins' input:

The issue with "Its in the product" is that 9/10 I just want to see your pricing plan options on your marketing screen, because to me this is a much better way of viewing it.

... and also my own experience as a Sentry champion at my last workplace prior to joining Sentry, where I was in the same boat as @chriswiggins (roughly: wtf why am I not on https://app.sentry.io/ can I please get to the pricing page without logging out oh well I guess I'll open an incognito window 🙄). Also, this gives a nice nudge to self-hosted users who have no other persistent reminder in-app right now that SaaS exists. "Homepage" by itself felt alone, more than two items seemed excessive, adding "Pricing" felt like it gives helpful context without being overwhelming.

Checked, menu still works fine on a small phone.

You okay with this approach?

(Technical reviewer note: I'm not sure about the logic around <Divider /> ... is it possible to have neither a user nor an organization? 🤔)

Screenshots

desktop

mobile

@ckj
Copy link
Copy Markdown
Member

ckj commented Apr 27, 2021

The footer felt way too distant.

Sure, but it is on the surface. This solution requires a click to discover.

If we do go the menu route, I'd prefer we just stick with a single Homepage link.

@chadwhitacre
Copy link
Copy Markdown
Member Author

I'd prefer we just stick with a single Homepage link.

Done in d7f252c. 👍

Screen Shot 2021-04-28 at 9 10 39 AM

@chadwhitacre
Copy link
Copy Markdown
Member Author

chadwhitacre commented Apr 28, 2021

Also, ftr, the left side of the footer is occupied by a version string in self-hosted. On the other hand there is also a "Migrate to SaaS" link in the footer on self-hosted, so I was wrong about there being no permanent reminder in-app.

Screen Shot 2021-04-28 at 9 12 02 AM

Sure, but it is on the surface. This solution requires a click to discover.

Fair enough. Maybe the lower left in the sidebar could work? "Help" is already navigating away from the app and "What's New" is already marketing-ish, so I think it fits pretty well conceptually (imo it does feel a bit out of place with the org/user menu, in addition to requiring a click to discover).

P.S. Not sure if bikeshedding or pixels-mattering at this point. 😬

Screen Shot 2021-04-28 at 9 31 19 AM

@evanpurkhiser
Copy link
Copy Markdown
Member

I feel a little be weary about linking out to the pricing page in the OSS project. Even in the SAAS product, we have a number of links that take you to the pricing page in a more contextual way.

Also in the open source version, you can just go to sentry.io, and it will take you to the home page.

I think we should make these changes in getsentry.

@chadwhitacre
Copy link
Copy Markdown
Member Author

chadwhitacre commented Apr 28, 2021

I feel a little be weary about linking out to the pricing page in the OSS project.

"Pricing" link was removed in d7f252c, now this just adds a link to "Homepage."

@chadwhitacre chadwhitacre changed the title feat(sidebar): Add links to marketing site feat(sidebar): Add link to marketing homepage inside product May 4, 2021
Copy link
Copy Markdown
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments but looks good

@chadwhitacre chadwhitacre merged commit 74d5f1a into master May 4, 2021
@chadwhitacre chadwhitacre deleted the cwlw/link-to-marketing branch May 4, 2021 20:38
JoshFerge pushed a commit that referenced this pull request May 4, 2021
chadwhitacre added a commit that referenced this pull request May 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a link to the marketing site from the product

3 participants