ref(ui) Remove legacy context from JsonForm#25931
Merged
Merged
Conversation
This required pushing defaultProps down to FormPanel (where they are actually used), and updating tests for sentry application publishing to query the modal. Because JsonForm is getting `location` from `withRouter()` we don't need to pass it in as a prop anymore.
evanpurkhiser
approved these changes
May 6, 2021
priscilawebdev
approved these changes
May 7, 2021
priscilawebdev
pushed a commit
that referenced
this pull request
May 11, 2021
This required pushing defaultProps down to FormPanel (where they are actually used), and updating tests for sentry application publishing to query the modal. Because JsonForm is getting `location` from `withRouter()` we don't need to pass it in as a prop anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required pushing defaultProps down to FormPanel (where they are actually used), and updating tests for sentry application publishing to query the modal.
Because JsonForm is getting
locationfromwithRouter()we don't need to pass it in as a prop anymore.