Skip to content

fix(issue-details-page): Fix release artifacts distribution error message#26423

Merged
priscilawebdev merged 2 commits into
masterfrom
fix/fix-release-artifact-distribution--error-message
Jun 7, 2021
Merged

fix(issue-details-page): Fix release artifacts distribution error message#26423
priscilawebdev merged 2 commits into
masterfrom
fix/fix-release-artifact-distribution--error-message

Conversation

@priscilawebdev

Copy link
Copy Markdown
Member

closes 390b486

@priscilawebdev priscilawebdev changed the title fix(issue-details-page): Fix release artifacts distribution fix(issue-details-page): Fix release artifacts distribution error message Jun 7, 2021
@priscilawebdev priscilawebdev force-pushed the fix/fix-release-artifact-distribution--error-message branch from a150c35 to 4cbcc15 Compare June 7, 2021 14:49
Comment thread static/app/components/events/errors.tsx Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use eventDistribution here instead? It just makes it clearer to the reader of the code which is which.

@lobsterkatie lobsterkatie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the variable naming question, LGTM!

Comment thread static/app/components/events/errors.tsx Outdated
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
@priscilawebdev priscilawebdev merged commit 4b163c2 into master Jun 7, 2021
@priscilawebdev priscilawebdev deleted the fix/fix-release-artifact-distribution--error-message branch June 7, 2021 18:40
jan-auer added a commit to knaperek/sentry that referenced this pull request Jun 8, 2021
* master: (368 commits)
  ref(ui) remove createReactClass from withTags, withTeams and withOrganizations (getsentry#26444)
  fix: Update symbolicator snapshots (getsentry#26455)
  ref(appconnect): Store when itunes session was refreshed (getsentry#26154)
  fix(discover): Minicard should not crash on empty results (getsentry#26454)
  meta: Add deprecation warning for js globals in custom plugins (getsentry#26425)
  feat: Add a project/status/last-seen index to sentry_groupedmessage (getsentry#26416)
  feat(ui): Add prev/next to release details (getsentry#26323)
  feat(api): Return first and last releases on date sort (getsentry#26417)
  perf(releases): Append-only version of release archive merge (getsentry#26424)
  feat: App store connect feature branch (getsentry#26446)
  fix(config): Remove static Relays from default server config (getsentry#26434)
  deps(pyjwt): try again to upgrade pyjwt (getsentry#26439)
  ref(jwt): Put JWT usage behind our own abstraction plus upgrade it (getsentry#26140)
  fix(workflow): Change %-based condition IntegerField into FloatField (getsentry#26412)
  feat(workflow): Add team and name filters to incident history (getsentry#26253)
  feat(sandbox): expose focus trap (getsentry#26414)
  fix(issue-details-page): Fix release artifacts distributon (getsentry#26423)
  added media breakpoint for search (getsentry#26415)
  ref(perf): Try increasing limit for histogram (getsentry#26376)
  feat(growth): redirect out of disabled member page (getsentry#26395)
  ...
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants