fix(discover): Minicard should not crash on empty results#26454
Merged
Zylphrex merged 1 commit intoJun 8, 2021
Conversation
Getting a colour palette for 0 items results in `undefined` which crashes with a TypeError.
wmak
approved these changes
Jun 8, 2021
Zylphrex
deleted the
fix/discover-mini-card-should-not-crash-on-empty-results
branch
jan-auer
added a commit
to knaperek/sentry
that referenced
this pull request
Jun 8, 2021
* master: (368 commits) ref(ui) remove createReactClass from withTags, withTeams and withOrganizations (getsentry#26444) fix: Update symbolicator snapshots (getsentry#26455) ref(appconnect): Store when itunes session was refreshed (getsentry#26154) fix(discover): Minicard should not crash on empty results (getsentry#26454) meta: Add deprecation warning for js globals in custom plugins (getsentry#26425) feat: Add a project/status/last-seen index to sentry_groupedmessage (getsentry#26416) feat(ui): Add prev/next to release details (getsentry#26323) feat(api): Return first and last releases on date sort (getsentry#26417) perf(releases): Append-only version of release archive merge (getsentry#26424) feat: App store connect feature branch (getsentry#26446) fix(config): Remove static Relays from default server config (getsentry#26434) deps(pyjwt): try again to upgrade pyjwt (getsentry#26439) ref(jwt): Put JWT usage behind our own abstraction plus upgrade it (getsentry#26140) fix(workflow): Change %-based condition IntegerField into FloatField (getsentry#26412) feat(workflow): Add team and name filters to incident history (getsentry#26253) feat(sandbox): expose focus trap (getsentry#26414) fix(issue-details-page): Fix release artifacts distributon (getsentry#26423) added media breakpoint for search (getsentry#26415) ref(perf): Try increasing limit for histogram (getsentry#26376) feat(growth): redirect out of disabled member page (getsentry#26395) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting a colour palette for 0 items results in
undefinedwhich crashes witha TypeError.
Fixes JAVASCRIPT-241M