Skip to content

py38: bump django-sudo to django2.2 + python3.8 compatible version #26602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuarli merged 1 commit into from
Jun 14, 2021
Merged

py38: bump django-sudo to django2.2 + python3.8 compatible version #26602

joshuarli merged 1 commit into from
Jun 14, 2021

Conversation

@joshuarli
Copy link
Member

@joshuarli joshuarli commented Jun 14, 2021 •
edited
Loading

I tested it to locally work. See also getsentry/django-sudo#1. Two parts.

One, the SudoRequired SentryAPIException -> frontend modal (tests our own sudo_required decorator for various API endpoints):

  • login, see the sudo cookie set
  • remove the cookie
  • visit /settings/account/security/session-history/ and seeing the popup
  • see that the cookie is restored

Two, the server-rendered redirect view

  • put sudo_required = True on ReactPageView bc i'm lazy
  • refreshed various pages and it works

@joshuarli joshuarli requested a review from billyvg June 14, 2021 20:11
@joshuarli joshuarli requested a review from a team as a code owner June 14, 2021 20:11
@joshuarli joshuarli added this to the python-3.8-upgrade milestone Jun 14, 2021
This was referenced Jun 14, 2021
Merged
Merged
@joshuarli joshuarli merged commit c051738 into master Jun 14, 2021
@joshuarli joshuarli deleted the py38/upgrade-django-sudo branch June 14, 2021 21:16
BYK added a commit that referenced this pull request Jun 15, 2021
@BYK
Revert "py38: bump django-sudo to django2.2, python3.8 compatible ver…
ae22f31 
…sion (#26602)"

This reverts commit c051738 as we
cannot have direct git/http dependencies to be able to publish to
PyPI.
billyvg pushed a commit that referenced this pull request Jun 15, 2021
@BYK
Revert "py38: bump django-sudo to django2.2, python3.8 compatible ver…
5e48538 
…sion (#26602)" (#26632)

This reverts commit c051738 as we
cannot have direct git/http dependencies to be able to publish to
PyPI.
AniketDas-Tekky pushed a commit that referenced this pull request Jun 15, 2021
@BYK
Revert "py38: bump django-sudo to django2.2, python3.8 compatible ver…
0b85d01 
…sion (#26602)" (#26632)

This reverts commit c051738 as we
cannot have direct git/http dependencies to be able to publish to
PyPI.
@joshuarli joshuarli mentioned this pull request Jun 15, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

python-3.8-upgrade

Development

Successfully merging this pull request may close these issues.

3 participants

@joshuarli @billyvg