Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jun 15, 2021

This reverts commit c051738 as we
cannot have direct git/http dependencies to be able to publish to
PyPI.

…sion (#26602)"

This reverts commit c051738 as we
cannot have direct git/http dependencies to be able to publish to
PyPI.
@BYK
Copy link
Member Author

BYK commented Jun 15, 2021

We either revert this or skip releasing to PyPI for 20.6.0

@evanpurkhiser
Copy link
Member

IMO we should continue with this revert and either do a prerelease on sudo or something like that

@billyvg
Copy link
Member

billyvg commented Jun 15, 2021

Is there a linter available to prohibit direct deps?

@BYK
Copy link
Member Author

BYK commented Jun 15, 2021

@billyvg

#26632 (comment)

Since this is the second time we have this issue, I'll write one 🙂

@billyvg
Copy link
Member

billyvg commented Jun 15, 2021

Merging this as we need to restore our latest docker tag

@billyvg billyvg merged commit 5e48538 into master Jun 15, 2021
@billyvg billyvg deleted the byk/fix/release branch June 15, 2021 17:58
AniketDas-Tekky pushed a commit that referenced this pull request Jun 15, 2021
…sion (#26602)" (#26632)

This reverts commit c051738 as we
cannot have direct git/http dependencies to be able to publish to
PyPI.
BYK added a commit that referenced this pull request Jun 23, 2021
This is to prevent incidents like #26632
BYK added a commit that referenced this pull request Jun 23, 2021
This is to prevent incidents like #26632
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants