Skip to content

ref(notification platform): Update formatting#27453

Merged
ceorourke merged 10 commits into
masterfrom
ceorourke/update-deploy-formatting
Jul 16, 2021
Merged

ref(notification platform): Update formatting#27453
ceorourke merged 10 commits into
masterfrom
ceorourke/update-deploy-formatting

Conversation

@ceorourke

Copy link
Copy Markdown
Member

Various updates to the notification platform Slack messages:

Updated Deploy Notification Format

We now shorten the release version as we do in the product and turn the links into buttons in a row
Before
Screen Shot 2021-07-14 at 3 41 01 PM

After
Screen Shot 2021-07-14 at 3 40 25 PM

Removed Bullet Points from Help Text

Before
Screen Shot 2021-07-14 at 3 43 29 PM

After
Screen Shot 2021-07-14 at 3 40 48 PM

Changed color of workflow notification attachment bar

Now only issue alerts are red, workflow notifications and deploy notifications use the "info" level blue
Before
Screen Shot 2021-07-14 at 3 44 47 PM

After
Screen Shot 2021-07-14 at 3 40 33 PM

@ceorourke ceorourke requested a review from a team July 14, 2021 22:46

@evanpurkhiser evanpurkhiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment thread src/sentry/integrations/slack/message_builder/issues.py
Comment thread src/sentry/notifications/activity/release.py Outdated
Comment thread src/sentry/integrations/slack/message_builder/notifications.py Outdated
Comment thread src/sentry/integrations/slack/message_builder/notifications.py Outdated
@mgaeta

mgaeta commented Jul 16, 2021

Copy link
Copy Markdown
Contributor

Now that text is optional we should be able to change the payload from

return {
    "text": text,
    "mrkdwn_in": ["text"],
    "color": LEVEL_TO_COLOR[color or "info"],
    **kwargs,
}

to

if text:
    kwargs["text"] = text
    kwargs["mrkdwn_in"] = ["text"]

return {
    "color": LEVEL_TO_COLOR[color or "info"],
    **kwargs,
}

@ceorourke ceorourke merged commit 8091b1e into master Jul 16, 2021
@ceorourke ceorourke deleted the ceorourke/update-deploy-formatting branch July 16, 2021 22:05
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants