ref(ts): Fix lint issues that are being masked#28454
Merged
Conversation
These are lint issues that will come up in a new version of `@typescript-eslint`. See getsentry/eslint-config-sentry#105
billyvg
commented
Sep 8, 2021
| !.github | ||
| !.github/workflows/scripts/* | ||
| !.storybook | ||
| *.d.ts |
| icon: React.ReactNode; | ||
| providerIds: string[]; | ||
| commitUrl: (CommitFormatterParameters) => string; | ||
| commitUrl: (opts: CommitFormatterParameters) => string; |
Comment on lines
+32
to
+34
| function getValueWithAnnotatedText(v: Value, meta?: Meta) { | ||
| return <AnnotatedText value={v} meta={meta} />; | ||
| } |
Member
Author
There was a problem hiding this comment.
I pulled this out because of no-shadow
| * Configure Emotion to use our theme | ||
| */ | ||
| declare module '@emotion/react' { | ||
| // eslint-disable-next-line @typescript-eslint/no-shadow |
Member
Author
There was a problem hiding this comment.
This only errors in the new version of @typescript-eslint
Comment on lines
+103
to
+104
| getProps<Q extends ExperimentType>() { | ||
| return this.props as unknown as ExpectedProps<Q>; |
| const codeMapping = codeMappings.find(mapping => mapping.id === codeMappingId); | ||
| const {integrationId, provider} = codeMapping as RepositoryProjectPathConfig; | ||
| const errActors = errorJSON?.raw?.[0].split('\n').map(el => <p>{el}</p>); | ||
| const errActors = errorJSON?.raw?.[0].split('\n').map((el, i) => <p key={i}>{el}</p>); |
Member
Author
There was a problem hiding this comment.
Not sure why this wasn't erroring... not great
evanpurkhiser
approved these changes
Sep 9, 2021
dashed
approved these changes
Sep 9, 2021
priscilawebdev
approved these changes
Sep 9, 2021
billyvg
deleted the
feat/ui/upgrade-typescript-eslint-and-fix-lint-errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are lint issues that will come up in a new version of
@typescript-eslint. See getsentry/eslint-config-sentry#105