fix(ui): move logic to styled component #29588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidenwang
approved these changes
Oct 26, 2021
| const FooterContainer = styled('div')` | ||
| const FooterContainer = styled('div')<{hasMessage: boolean}>` | ||
| display: flex; | ||
| justify-content: ${p => (p.hasMessage ? 'space-between' : 'flex-end')}; |
Contributor
There was a problem hiding this comment.
do we need the parentheses here around p.hasMessage ? ... 'flex-end'
Contributor
Author
There was a problem hiding this comment.
@davidenwang I believe prettier added them for me
Member
There was a problem hiding this comment.
that's correct it's prettier
evanpurkhiser
approved these changes
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving logic from inline to the styled component