fix(suspect-spans): Support has filter on span columns #29665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the has filter on span columns. Also fixes the actual condition generated as that was previously incorrect.
wmak
approved these changes
Oct 29, 2021
src/sentry/search/events/filter.py
Outdated
| 1, | ||
| Function("notEmpty", [self.column(name)]), | ||
| Op.EQ, | ||
| 1 if search_filter.operator == "!=" else 0, |
Member
There was a problem hiding this comment.
Thoughts on changing this in the operator parameter instead of changing the value?
Member
Author
There was a problem hiding this comment.
No strong opinions there, as I was just aiming to be in parity with the original JSON implementation (minus hacks like arrayConcat)
Member
There was a problem hiding this comment.
k, gonna start(i dont think we are today) pushing for consistency and have us change the operator instead of the value when possible
Member
Author
There was a problem hiding this comment.
Sounds good, i can update this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the has filter on span columns. Also fixes the actual
condition generated as that was previously incorrect.