Skip to content

fix(suspect-spans): Support has filter on span columns #29665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 3 commits into from
Nov 1, 2021
Merged

fix(suspect-spans): Support has filter on span columns #29665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42b9676
fix(suspect-spans): Support has filter on span columns
Zylphrex Oct 29, 2021
2371cfa
Merge branch 'master' into fix/support-has-filter-on-span-columns
Zylphrex Oct 29, 2021
1eecfcf
be consistent by changing the operator instead of the value
Zylphrex Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sentry/search/events/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@
"stack.module",
"stack.package",
"stack.stack_level",
"spans_op",
"spans_group",
"spans_exclusive_time",
}

CONFIGURABLE_AGGREGATES = {
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/search/events/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,8 +1352,8 @@ def _default_filter_converter(self, search_filter: SearchFilter) -> Optional[Whe
)
elif name in ARRAY_FIELDS and search_filter.value.raw_value == "":
return Condition(
Function("hasAny", [self.column(name), []]),
Op.EQ if search_filter.operator == "=" else Op.NEQ,
Function("notEmpty", [self.column(name)]),
Op.EQ if search_filter.operator == "!=" else Op.NEQ,
1,
)

Expand Down
38 changes: 38 additions & 0 deletions tests/sentry/snuba/test_discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2190,6 +2190,44 @@ def test_array_fields(self):
assert len(data[0]["stack.filename"]) == len(expected_filenames)
assert sorted(data[0]["stack.filename"]) == expected_filenames

@pytest.mark.skip("setting snuba config is too slow")
def test_spans_op_array_field(self):
trace_context = {
"parent_span_id": "8988cec7cc0779c1",
"type": "trace",
"op": "http.server",
"trace_id": "a7d67cf796774551a95be6543cacd459",
"span_id": "babaae0d4b7512d9",
"status": "ok",
"hash": "a" * 16,
"exclusive_time": 1.2345,
}
data = load_data(
"transaction", timestamp=before_now(minutes=10), trace_context=trace_context, spans=[]
)
self.store_event(data=data, project_id=self.project.id)

queries = [
("has:spans_op", 1),
("!has:spans_op", 0),
]

for use_snql in [False, True]:
for query, expected_len in queries:
result = discover.query(
selected_columns=["spans_op"],
query=query,
params={
"organization_id": self.organization.id,
"project_id": [self.project.id],
"start": before_now(minutes=12),
"end": before_now(minutes=8),
},
use_snql=use_snql,
)
data = result["data"]
assert len(data) == expected_len, use_snql

def test_orderby_field_alias(self):
data = load_data("android-ndk", timestamp=before_now(minutes=10))
events = (
Expand Down