Skip to content

fix(perf): Fix issues widget for frontend view #29845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-fish merged 2 commits into from
Nov 8, 2021
Merged

fix(perf): Fix issues widget for frontend view #29845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d89e23
fix(perf): Fix issues widget for frontend view
k-fish Nov 8, 2021
bbd4835
Also remove the negation of transaction.op field for frontend other.
k-fish Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ export function LineChartListWidget(props: Props) {
eventView.additionalConditions.setFilterValues('!tags[transaction]', ['']);
const mutableSearch = new MutableSearch(eventView.query);
mutableSearch.removeFilter('transaction.duration');
eventView.additionalConditions.removeFilter('transaction.op'); // Remove transaction op incase it's applied from the performance view.
eventView.additionalConditions.removeFilter('!transaction.op'); // Remove transaction op incase it's applied from the performance view.
eventView.query = mutableSearch.formatString();
} else if (isSlowestType) {
eventView.additionalConditions.setFilterValues('epm()', ['>0.01']);
Expand Down Expand Up @@ -149,6 +151,8 @@ export function LineChartListWidget(props: Props) {
]);
eventView.additionalConditions.setFilterValues('event.type', ['error']);
eventView.additionalConditions.setFilterValues('!tags[transaction]', ['']);
eventView.additionalConditions.removeFilter('transaction.op'); // Remove transaction op incase it's applied from the performance view.
eventView.additionalConditions.removeFilter('!transaction.op'); // Remove transaction op incase it's applied from the performance view.
const mutableSearch = new MutableSearch(eventView.query);
mutableSearch.removeFilter('transaction.duration');
eventView.query = mutableSearch.formatString();
Expand Down
23 changes: 14 additions & 9 deletions tests/js/spec/views/performance/landing/widgets/widgetContainer.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ import {PerformanceWidgetSetting} from 'app/views/performance/landing/widgets/wi
import {PROJECT_PERFORMANCE_TYPE} from 'app/views/performance/utils';

const initializeData = () => {
return _initializeData({
const data = _initializeData({
query: {statsPeriod: '7d', environment: ['prod'], project: [-42]},
});

data.eventView.additionalConditions.addFilterValues('transaction.op', ['pageload']);

return data;
};

const WrappedComponent = ({data, ...rest}) => {
Expand Down Expand Up @@ -78,7 +82,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
query: expect.objectContaining({
interval: '1h',
partial: '1',
query: '',
query: 'transaction.op:pageload',
statsPeriod: '14d',
yAxis: 'tpm()',
}),
Expand Down Expand Up @@ -110,7 +114,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
query: expect.objectContaining({
interval: '1h',
partial: '1',
query: '',
query: 'transaction.op:pageload',
statsPeriod: '14d',
yAxis: 'failure_rate()',
}),
Expand Down Expand Up @@ -142,7 +146,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
query: expect.objectContaining({
interval: '1h',
partial: '1',
query: '',
query: 'transaction.op:pageload',
statsPeriod: '14d',
yAxis: 'user_misery()',
}),
Expand Down Expand Up @@ -186,7 +190,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
],
per_page: 3,
project: ['-42'],
query: '',
query: 'transaction.op:pageload',
sort: '-count_if(measurements.lcp,greaterOrEquals,4000)',
statsPeriod: '7d',
}),
Expand Down Expand Up @@ -260,7 +264,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
field: ['transaction', 'project.id', 'failure_count()'],
per_page: 3,
project: ['-42'],
query: 'failure_count():>0',
query: 'transaction.op:pageload failure_count():>0',
sort: '-failure_count()',
statsPeriod: '7d',
}),
Expand Down Expand Up @@ -331,7 +335,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
per_page: 3,
project: ['-42'],
query:
'tpm():>0.01 count_percentage():>0.25 count_percentage():<4 trend_percentage():>0% confidence():>6',
'transaction.op:pageload tpm():>0.01 count_percentage():>0.25 count_percentage():<4 trend_percentage():>0% confidence():>6',
sort: 'trend_percentage()',
statsPeriod: '7d',
trendFunction: 'avg(transaction.duration)',
Expand Down Expand Up @@ -370,7 +374,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
per_page: 3,
project: ['-42'],
query:
'tpm():>0.01 count_percentage():>0.25 count_percentage():<4 trend_percentage():>0% confidence():>6',
'transaction.op:pageload tpm():>0.01 count_percentage():>0.25 count_percentage():<4 trend_percentage():>0% confidence():>6',
sort: '-trend_percentage()',
statsPeriod: '7d',
trendFunction: 'avg(transaction.duration)',
Expand Down Expand Up @@ -412,7 +416,8 @@ describe('Performance > Widgets > WidgetContainer', function () {
],
per_page: 3,
project: ['-42'],
query: 'epm():>0.01 p75(measurements.frames_slow_rate):>0',
query:
'transaction.op:pageload epm():>0.01 p75(measurements.frames_slow_rate):>0',
sort: '-p75(measurements.frames_slow_rate)',
statsPeriod: '7d',
}),
Expand Down