Skip to content

fix(new-widget-builder-experience): Add queries to handleBlur dependency list #33260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
narsaynorath merged 2 commits into from
Apr 4, 2022
Merged

fix(new-widget-builder-experience): Add queries to handleBlur dependency list #33260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
182aff7
fix(new-widget-builder-experience): Add queries to hook dependency list
narsaynorath Apr 4, 2022
f03f4af
fix(new-widget-builder-experience): Add test
narsaynorath Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions static/app/views/dashboardsV2/widgetBuilder/buildSteps/filterResultsStep/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,20 @@ export function FilterResultsStep({
};
}, []);

const handleBlur = useCallback((queryIndex: number) => {
return (field: string) => {
if (!blurTimeoutRef.current) {
const newQuery: WidgetQuery = {
...queries[queryIndex],
conditions: field,
};
onQueryChange(queryIndex, newQuery);
}
};
}, []);
const handleBlur = useCallback(
(queryIndex: number) => {
return (field: string) => {
if (!blurTimeoutRef.current) {
const newQuery: WidgetQuery = {
...queries[queryIndex],
conditions: field,
};
onQueryChange(queryIndex, newQuery);
}
};
},
[queries]
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that was the queries... funny, I would have fixed this in the PR #33241

Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev Apr 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to do the same with handleSearch 😉

);

return (
<BuildStep
Expand Down
47 changes: 46 additions & 1 deletion tests/js/spec/views/dashboardsV2/widgetBuilder/widgetBuilder.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {urlEncode} from '@sentry/utils';

import {initializeOrg} from 'sentry-test/initializeOrg';
import {mountGlobalModal} from 'sentry-test/modal';
import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
import {act, render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
import {textWithMarkupMatcher} from 'sentry-test/utils';

import * as indicators from 'sentry/actionCreators/indicator';
Expand Down Expand Up @@ -177,6 +177,7 @@ describe('WidgetBuilder', function () {
afterEach(function () {
MockApiClient.clearMockResponses();
jest.clearAllMocks();
jest.useRealTimers();
});

it('no feature access', function () {
Expand Down Expand Up @@ -1062,6 +1063,50 @@ describe('WidgetBuilder', function () {
});
});

it('does not error when query conditions field is blurred', async function () {
jest.useFakeTimers();
const widget: Widget = {
id: '0',
title: 'sdk usage',
interval: '5m',
displayType: DisplayType.BAR,
queries: [
{
name: 'filled in',
conditions: 'event.type:error',
fields: ['count()', 'count_unique(id)'],
aggregates: ['count()', 'count_unique(id)'],
columns: [],
orderby: '-count',
},
],
};

const dashboard: DashboardDetails = {
id: '1',
title: 'Dashboard',
createdBy: undefined,
dateCreated: '2020-01-01T00:00:00.000Z',
widgets: [widget],
};

const handleSave = jest.fn();

renderTestComponent({dashboard, onSave: handleSave, params: {widgetIndex: '0'}});

userEvent.click(await screen.findByLabelText('Add Query'));

// Triggering the onBlur of the new field should not error
userEvent.click(
screen.getAllByPlaceholderText('Search for events, users, tags, and more')[1]
);
userEvent.keyboard('{esc}');
act(() => {
// Run all timers because the handleBlur contains a setTimeout
jest.runAllTimers();
});
});

describe('Sort by selectors', function () {
it('renders', async function () {
renderTestComponent({
Expand Down