ref(js): Remove componentPromise from Route props#34983
Merged
evanpurkhiser merged 1 commit intoMay 25, 2022
Merged
Conversation
evanpurkhiser
commented
May 25, 2022
| * Factory function to produce a component that will render the SafeLazyLoad | ||
| * _with_ the required props. | ||
| */ | ||
| function make<C extends ComponentType>(resolve: () => PromisedImport<C>) { |
Member
Author
There was a problem hiding this comment.
Can maybe rename this later to something better
Member
There was a problem hiding this comment.
yes it would be nice if the name is more descriptive
Member
Author
There was a problem hiding this comment.
I named it this since this file only really does one thing make routes, lol
Member
There was a problem hiding this comment.
Could call it loadRoute() or importView() 🤷
Member
Author
There was a problem hiding this comment.
I just wanted it to be short so it doesn't wrap too many entires 😅
I figure since it's one of the only functions in this file, a short name is OK -- since it's used like 300 times
priscilawebdev
approved these changes
May 25, 2022
dashed
approved these changes
May 25, 2022
evanpurkhiser
deleted the
evanpurkhiser/ref-js-remove-componentpromise-from-route-props
branch
evanpurkhiser
added a commit
that referenced
this pull request
May 25, 2022
This reverts commit 7bed103.
getsentry-bot
added a commit
that referenced
this pull request
May 25, 2022
This reverts commit 7bed103. Co-authored-by: evanpurkhiser via Slack <evan.purkhiser@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step towards moving away from react-router 3