ref(django-3.2): Vendor django picklefield

[AniketDas-Tekky]

Django-picklefield hasn't been updated in 2 years, but we need it. We also need to upgrade to django 3.2 which means we need to update picklefield.

Could use some direction on the direction struture changes

[evanpurkhiser]

Where are we using this? How feasible would it be to kill off usage of pickle in favor of JSON?

[AniketDas-Tekky]

Where are we using this? How feasible would it be to kill off usage of pickle in favor of JSON?

We use it in authentication and all option models. I think we should remove this, but it's outside the scope of django 3.2 upgrade.

[asottile-sentry]

the package name needs to be an underscore -- that's why the testsuite is failing

[chadwhitacre]

Can we fork and maintain?

[AniketDas-Tekky]

Can we fork and maintain?

Long term, this is the right approach (or removing it entirely). However, for django 3.2 upgrade, we only need to update a couple of lines to make it compatible. So this is a quick fix, until we get some time to set up our own fork.

FWIW, I did fork it already, but there's no CI. https://github.com/getsentry/django-picklefield

[chadwhitacre]

we only need to update a couple of lines to make it compatible

Can we make the changes in the fork and reference it via a git URL in requirements.txt? Avoids the overhead of releasing but keeps us on the right path w/ the fork.

[chadwhitacre]

Also not that hard to set up releases via the publish repo. ;)

[asottile-sentry]

we only need to update a couple of lines to make it compatible

Can we make the changes in the fork and reference it via a git URL in requirements.txt? Avoids the overhead of releasing but keeps us on the right path w/ the fork.

at the moment our requirements require pkg==... and forbid git urls (because we can't publish with them)

we could publish a sentry-django-picklefield though

[joshuarli]

I still think vendoring is the easiest and best option here, given that:

• it's such a small amount of code (easy to vendor)
• MIT license, no issues there I don't think
• there's potential to remove it in the future and having it vendored might help (flexibility for transitional changes)

Granted, we should try to also upstream any improvements and compat changes we make.

[asottile-sentry]

[joshuarli]

You can remove the version related contents of this file, it's not needed anymore.