ref(issueDetails); Remove bottom margin on ConfigureDistributedTracing panel#37957
Closed
vuluongj20 wants to merge 1 commit into
Closed
ref(issueDetails); Remove bottom margin on ConfigureDistributedTracing panel#37957vuluongj20 wants to merge 1 commit into
vuluongj20 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
| background: none; | ||
| padding: ${space(2)}; | ||
| margin: ${space(2)} 0; | ||
| margin: ${space(2)} 0 0; |
Member
There was a problem hiding this comment.
should this just be margin-top then?
Contributor
Author
There was a problem hiding this comment.
Panel has its own set of margins, so we need to reset it here.
vuluongj20
commented
Aug 17, 2022
| background: none; | ||
| padding: ${space(2)}; | ||
| margin: ${space(2)} 0; | ||
| margin: ${space(2)} 0 0; |
Contributor
Author
There was a problem hiding this comment.
What this looks like without the alert:
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: there's too much space between the panel and the error alert
After:
