chore(auth): Update sentry.identity.oauth2 to support customer domains#39052
Merged
chore(auth): Update sentry.identity.oauth2 to support customer domains#39052
Conversation
github-actions
bot
added
the
Scope: Backend
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline
branch
from
c5690c8 to
0ec004c
Compare
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline-pt-2
branch
from
c5dd56f to
0f9c583
Compare
markstory
reviewed
Sep 20, 2022
tests/sentry/identity/test_oauth2.py
Outdated
Member
There was a problem hiding this comment.
Was responses not able to do the mocking you needed? It should be able to mock out anything using urllib3.
Member
Author
There was a problem hiding this comment.
@markstory I added asserts to check the arguments passed to safe_urlopen() for the token exchange.
Member
There was a problem hiding this comment.
You can do that with responses as well. responses.calls gives you access to all the requests that were made and the url/parameters that were used for each mocked request.
Member
|
Untagging ecosystem. Retag if our review is needed. |
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline
branch
from
0ec004c to
fec27dd
Compare
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline-pt-2
branch
from
0f9c583 to
8039526
Compare
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline
branch
from
fec27dd to
8d9f92f
Compare
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline-pt-2
branch
from
8039526 to
1728d32
Compare
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline-pt-2
branch
from
1728d32 to
8595bc7
Compare
Base automatically changed from
hybrid-cloud/oauth2-customer-domains-pipeline
to
master
September 28, 2022 17:53
dashed
force-pushed
the
hybrid-cloud/oauth2-customer-domains-pipeline-pt-2
branch
from
8595bc7 to
132db8d
Compare
maxiuyuan
approved these changes
Oct 4, 2022
| provider_key=view.provider_key, | ||
| config=view.config, | ||
| ) | ||
| return nested_pipeline.fetch_state(key) |
Member
There was a problem hiding this comment.
Why didn’t you just put this in the base pipeline fetch_state?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches from #39016.
This delegates the pipeline redis store to propagate customer domain information for the OAuth2 implementation that resides in
sentry.identity.oauth2.