Skip to content

fix(issues): Consistent owned-by sizing#39639

Merged
scttcper merged 1 commit into
masterfrom
scttcper/owned-by-size
Oct 4, 2022
Merged

fix(issues): Consistent owned-by sizing#39639
scttcper merged 1 commit into
masterfrom
scttcper/owned-by-size

Conversation

@scttcper

@scttcper scttcper commented Oct 4, 2022

Copy link
Copy Markdown
Member

Fixes an issue with the unassigned avatar size, increases both the unassigned avatar and the assigned avatar.

before
image

after
image

Fixes an issue with the unassigned avatar size, increases both the unassigned avatar and the assigned avatar.
@scttcper scttcper requested a review from a team October 4, 2022 21:59
@scttcper scttcper requested a review from a team as a code owner October 4, 2022 21:59
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 4, 2022
/>
) : (
<IconUser size="md" />
<IconWrapper>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 damn do we need it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the sizing was broken because of using svg inside flexbox

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or at least wrapping it in a div fixed the issue, and then it wasn't aligned so it needed to have display flex

@scttcper scttcper merged commit 976977b into master Oct 4, 2022
@scttcper scttcper deleted the scttcper/owned-by-size branch October 4, 2022 23:06
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants