Skip to content

feat(saved-searches): Design tweaks#41206

Merged
malwilley merged 12 commits into
masterfrom
malwilley/feat/saved-searches-design-tweaks
Nov 10, 2022
Merged

feat(saved-searches): Design tweaks#41206
malwilley merged 12 commits into
masterfrom
malwilley/feat/saved-searches-design-tweaks

Conversation

@malwilley

@malwilley malwilley commented Nov 9, 2022

Copy link
Copy Markdown
Member
  • Saved search items
    • Tighten up padding
    • Change visibility copy to be more explicit
    • Only show overflow menus on hover (for non-mobile)
  • Change tab text "My Pinned Search" => "My Default Search"
  • Change success message copy when adding/removing a default search
  • Change "Recommended" => "Recommended Searches"

Before/after:

imageimage

@malwilley malwilley requested review from a team and robinrendle November 9, 2022 23:39
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 9, 2022
@malwilley malwilley changed the title feat(saved-searches): feat(saved-searches): Design tweaks Nov 9, 2022
@github-actions

github-actions Bot commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 20.06 KB (+0.03% 🔺)
src/sentry/static/sentry/dist/entrypoints/sentry.css 33.06 KB (0%)

@davidenwang davidenwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@malwilley malwilley merged commit 20b0928 into master Nov 10, 2022
@malwilley malwilley deleted the malwilley/feat/saved-searches-design-tweaks branch November 10, 2022 19:21
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants