fix(profiling): ts fails to infer | null#43762
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Zylphrex
approved these changes
Jan 26, 2023
| export function useCurrentProjectFromRouteParam(): Project | null { | ||
| const params = useParams(); | ||
| const projects = useProjects({limit: 1, slugs: [params?.projectId]}); | ||
| return projects.projects?.[0] ?? null; |
Member
There was a problem hiding this comment.
Why did this fail to infer?
Member
There was a problem hiding this comment.
It's because we don't have noUncheckedIndexedAccess, so it thinks the type will ALWAYS be Project.
mikejihbe
pushed a commit
that referenced
this pull request
Feb 6, 2023
It seems TS fails to infer Project|null return type which caused a runtime error when we attempted to access project.slug property on null <img width="463" alt="CleanShot 2023-01-26 at 16 57 13@2x" src="https://user-images.githubusercontent.com/9317857/214966041-7e142dee-149f-46d5-9f3f-bc66476aef01.png">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems TS fails to infer Project|null return type which caused a runtime error when we attempted to access project.slug property on null