feat(replays): Give users an informative message when loading Replay Preview fails#44000
Merged
feat(replays): Give users an informative message when loading Replay Preview fails#44000
Conversation
github-actions
bot
added
the
Scope: Frontend
Contributor
size-limit report 📦
|
billyvg
reviewed
Feb 3, 2023
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Member
|
do we still want to merge this? |
ryan953
commented
Mar 20, 2023
ryan953
commented
Mar 20, 2023
ryan953
requested review from
a team,
billyvg and
evanpurkhiser
and removed request for
billyvg and
evanpurkhiser
ryan953
force-pushed
the
ryan953/nice-replay-preview-load-fail
branch
from
5633515 to
863f681
Compare
billyvg
approved these changes
Mar 20, 2023
Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the replay fails to load for some reason we can show some reasons why, in future we should expand on this by linking out the product docs.
Fixes #43965
Fixes #45841
Fixes https://github.com/getsentry/team-replay/issues/47