feat(roles): Info tooltip for org-roles#46613
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
nhsiehgit
reviewed
Mar 30, 2023
leedongwei
force-pushed
the
dlee/roles-tooltip
branch
from
bf42987 to
ce10f5b
Compare
Comment on lines
+34
to
+41
| if (!orgRoleFromMember) { | ||
| Sentry.withScope(scope => { | ||
| scope.setExtra('context', { | ||
| memberId: member.id, | ||
| orgRole: member.orgRole, | ||
| }); | ||
| Sentry.captureException(new Error('OrgMember has an invalid orgRole.')); | ||
| }); |
Member
There was a problem hiding this comment.
You probably want this to be in a useEffect right?
Contributor
Author
There was a problem hiding this comment.
There's no side-effects here. This component doesn't maintain state or change state.
Member
There was a problem hiding this comment.
Sentry.captureExceotion is a side effect, we don’t want that firing when the component rerenders
Contributor
Author
There was a problem hiding this comment.
Oh yea, I understand now. Fixed.
Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com>
Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com>
evanpurkhiser
approved these changes
Mar 31, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can get org-roles from several sources so we need a common component to bring people into docs for a thorough explanation.