feat(perf-issues): Replace sentence keys with snake case in backend #47830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
udameli
approved these changes
Apr 24, 2023
Member
Author
|
Converting to draft until I resolve the new name change |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47830 +/- ##
=======================================
Coverage 80.84% 80.85%
=======================================
Files 4765 4765
Lines 201456 201421 -35
Branches 11570 11566 -4
=======================================
- Hits 162874 162850 -24
+ Misses 38326 38315 -11
Partials 256 256
|
…ce-keys-with-snake-case-backend
narsaynorath
added a commit
that referenced
this pull request
Apr 27, 2023
…47850) Converts: Encoded Body Size -> http.response_content_length Decoded Body Size -> http.decoded_response_content_length Transfer Size -> http.response_transfer_size Also ensures that call sites fallback to old keys if the new keys aren't accessible. This PR should land before the backend PR: #47830
narsaynorath
deleted the
nar/feat/performance-issues-replace-sentence-keys-with-snake-case-backend
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces usages of "Encoded Body Size", "Decoded Body Size", "Transfer Size" with their snake case counterparts. This is for standardizing with OTel formatting in SDKs.
Should be merged after #47850
Motivating discussion: getsentry/sentry-javascript#7935 (comment)