Skip to content

Conversation

@narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Apr 24, 2023

Converts:
Encoded Body Size -> encoded_body_size
Decoded Body Size -> decoded_body_size
Transfer Size -> transfer_size

Also ensures that call sites fallback to old keys if the new keys aren't accessible.

This PR should land before the backend PR: #47830

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 24, 2023
@narsaynorath narsaynorath changed the title feat(perf-issues): Change Sentence keys to camel-case in frontend feat(perf-issues): Replace Sentence keys with camel-case in frontend Apr 24, 2023
@narsaynorath narsaynorath marked this pull request as ready for review April 24, 2023 19:15
@narsaynorath narsaynorath requested a review from a team April 24, 2023 19:15
@narsaynorath narsaynorath requested a review from a team as a code owner April 24, 2023 19:15
@narsaynorath narsaynorath marked this pull request as draft April 25, 2023 17:50
@narsaynorath
Copy link
Member Author

Converting to draft until I resolve the new name change

@narsaynorath narsaynorath force-pushed the nar/feat/performance-issues-replace-sentence-keys-with-snake-case-frontend branch from e10b4dd to 7a7e2dc Compare April 26, 2023 15:49
…snake-case-frontend' of github.com:getsentry/sentry into nar/feat/performance-issues-replace-sentence-keys-with-snake-case-frontend
@narsaynorath narsaynorath marked this pull request as ready for review April 27, 2023 14:55
@narsaynorath narsaynorath enabled auto-merge (squash) April 27, 2023 15:47
@narsaynorath narsaynorath merged commit 4fd9679 into master Apr 27, 2023
@narsaynorath narsaynorath deleted the nar/feat/performance-issues-replace-sentence-keys-with-snake-case-frontend branch April 27, 2023 16:10
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants