Skip to content

Permit almost anything for releases again #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitsuhiko merged 2 commits into from
Mar 6, 2017
Merged

Permit almost anything for releases again #5022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2907539
Permit almost anything for releases again
mitsuhiko Mar 2, 2017
700cffc
Updated a test for releases to contain a special character
mitsuhiko Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/sentry/api/endpoints/project_releases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
from sentry.utils.apidocs import scenario, attach_scenarios


BAD_RELEASE_CHARS = '\n\f\t/'
Copy link
Contributor

@Sija Sija Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is many other special chars like \r or \0, why not use proper regex allowing only the ones in ASCII range?



@scenario('CreateNewRelease')
def create_new_release_scenario(runner):
runner.request(
Expand All @@ -42,15 +45,20 @@ def list_releases_scenario(runner):


class ReleaseSerializer(serializers.Serializer):
version = serializers.RegexField(r'^[a-zA-Z0-9\-_\. \(\)]+\Z',
max_length=64, required=True)
version = serializers.CharField(max_length=64, required=True)
ref = serializers.CharField(max_length=64, required=False)
url = serializers.URLField(required=False)
owner = UserField(required=False)
dateStarted = serializers.DateTimeField(required=False)
dateReleased = serializers.DateTimeField(required=False)
commits = ListField(child=CommitSerializer(), required=False)

def validate_version(self, attrs, source):
value = attrs[source]
if any(c in value for c in BAD_RELEASE_CHARS) or value in ('.', '..'):
raise serializers.ValidationError('Invalid value for release')
return attrs


class ProjectReleasesEndpoint(ProjectEndpoint):
doc_section = DocSection.RELEASES
Expand Down
4 changes: 2 additions & 2 deletions tests/sentry/api/endpoints/test_organization_releases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,11 @@ def test_version_whitespace(self):
assert response.status_code == 400, response.content

response = self.client.post(url, data={
'version': '1.2.3',
'version': '1.2.3+dev',
'projects': [project.slug]
})
assert response.status_code == 201, response.content
assert response.data['version'] == '1.2.3'
assert response.data['version'] == '1.2.3+dev'

release = Release.objects.get(
organization_id=org.id,
Expand Down