feat(issue-details): Render the event replay in its own separate section#53120
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/feat/break-out-replay-section
branch
from
d6a2d58 to
0f6a5e4
Compare
ryan953
reviewed
Jul 19, 2023
| return null; | ||
| } | ||
|
|
||
| return <EventReplayContent {...{projectSlug, event, group}} />; |
Member
There was a problem hiding this comment.
does typescript check the props when we use spreads like this? checking for missing & extra props mainly
Member
Author
There was a problem hiding this comment.
You know, I never stopped to think about this but spreading any object actually doesn't error on excess props. It does still error when you have missing props though
ryan953
reviewed
Jul 19, 2023
ryan953
approved these changes
Jul 19, 2023
Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #46162
The moves the event replay out of the breadcrumbs section and into its own. Because performance issues can lack breadcrumbs, we needed to do this in order to display replays in all issue types.
The work here does the following:
interfaces/breadcrumbs/index.tsxtoevents/eventReplay/index.tsxEventReplayinside ofGroupEventDetailsContent, which adds it to the issue details pageEventReplayinside ofEventEntries, which adds it to the event views in discover and performanceReplayPreviewso that the initial timestamp falls back toevent.dateReceivedifdate.eventCreateddoes not exist (transaction events do not have adateCreated).