Skip to content

ref(crons): Guard _try_handle_high_volume_task_trigger#54319

Merged
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-crons-guard-try-handle-high-volume-task-trigger
Aug 7, 2023
Merged

ref(crons): Guard _try_handle_high_volume_task_trigger#54319
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-crons-guard-try-handle-high-volume-task-trigger

Conversation

@evanpurkhiser

Copy link
Copy Markdown
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner August 7, 2023 19:45
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 7, 2023

@rjo100 rjo100 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to test this via test_high_volume_task_trigger?

@evanpurkhiser

Copy link
Copy Markdown
Member Author

Sure, I can have something trigger an exception

@codecov

codecov Bot commented Aug 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #54319 (291eeae) into master (8ccd68e) will increase coverage by 0.00%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #54319   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files        4985     4985           
  Lines      211345   211353    +8     
  Branches    36025    36026    +1     
=======================================
+ Hits       168359   168367    +8     
- Misses      37807    37808    +1     
+ Partials     5179     5178    -1     
Files Changed Coverage Δ
...ews/replays/detail/domMutations/domMutationRow.tsx 0.00% <ø> (ø)
src/sentry/monitors/consumers/monitor_consumer.py 88.74% <100.00%> (+0.58%) ⬆️

... and 7 files with indirect coverage changes

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-guard-try-handle-high-volume-task-trigger branch from 04823a7 to 4f8e75b Compare August 7, 2023 21:46
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-guard-try-handle-high-volume-task-trigger branch from 4f8e75b to dcf77a7 Compare August 7, 2023 22:15
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-guard-try-handle-high-volume-task-trigger branch from dcf77a7 to 291eeae Compare August 7, 2023 22:28
@evanpurkhiser evanpurkhiser merged commit 9a2cbd3 into master Aug 7, 2023
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-guard-try-handle-high-volume-task-trigger branch August 7, 2023 22:57
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants