feat(starfish): Change how span samples are accessed - #54738
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
AbhiPrasad
commented
Aug 14, 2023
Contributor
Author
There was a problem hiding this comment.
I made the label a link
I can also add a button if that makes more sense here
gggritso
approved these changes
Aug 15, 2023
gggritso
left a comment
gggritso
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! As for pageFilter I think using it is fine since the span summary page is for a given project. That's a loose constraint though, so fetching the project.id from the backend would be safer if you want to do that
Contributor
Author
Going to do this in a follow up PR, and add the project icon while I'm at it |
AbhiPrasad
force-pushed
the
abhi-span-summary-change
branch
from
August 15, 2023 15:09
57d3e5e to
cbe1108
Compare
AbhiPrasad
enabled auto-merge (squash)
August 15, 2023 15:14
AbhiPrasad
added a commit
that referenced
this pull request
Aug 16, 2023
In #54738 we made some updates to the span sample drawer. This PR builds on top of it, specifically re: passing down projects. The PR removes the usage of pagefilters in favour of injected project id props and then adds a project avatar on the span sample page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per our newest set of requirements, update the span summary view table to now have the transaction name link to the span sample popout.
There is no longer anything linked to the average duration marker.
My only question is the usage of
pageFilterhook to get project - should I query for the project instead given we are going to support querying multiple projects?In the next PR I'm going to take a look at revamping the span sample chart based on design review given we want to change the triangles again.