Skip to content

fix(issue-details): Fix 'Open in Discover' button when on the All Events tab#54912

Merged
malwilley merged 1 commit into
masterfrom
malwilley/fix/open-in-discover-issueid
Aug 17, 2023
Merged

fix(issue-details): Fix 'Open in Discover' button when on the All Events tab#54912
malwilley merged 1 commit into
masterfrom
malwilley/fix/open-in-discover-issueid

Conversation

@malwilley

@malwilley malwilley commented Aug 17, 2023

Copy link
Copy Markdown
Member

Fixes #54787

Previously, clicking the "Open in Discover" button (only when on the All Events tab) would take you to the discover page with an empty query. This is because the useCleanQueryParamsOnRouteLeave was being applied on all navigations. The hook only needs to be applied when navigating between issue details tabs.

@malwilley malwilley requested a review from a team August 17, 2023 00:34
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 17, 2023

@scttcper scttcper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nasty tbh

@malwilley malwilley merged commit 3f2a213 into master Aug 17, 2023
@malwilley malwilley deleted the malwilley/fix/open-in-discover-issueid branch August 17, 2023 17:35
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues > "Open in discover" does not work if you are on the "All Events" tab.

2 participants