Move imports out of local scope in unmerge task. #5520
Conversation
| from sentry.models import Environment, GroupRelease, Project, Release | ||
|
|
||
| return { | ||
| 'Environment': cache( |
There was a problem hiding this comment.
These could be modified back to direct model class references, I don't have a strong preference on whether that change should be made or not.
src/sentry/tasks/unmerge.py
Outdated
| return result | ||
|
|
||
|
|
||
| def get_culprit(event): |
There was a problem hiding this comment.
This could go back to a lambda function.
|
|
||
|
|
||
| def get_event_score(caches, data, event): | ||
| from sentry.event_manager import ScoreClause |
There was a problem hiding this comment.
This could go back to a lambda function.
JTCunning
left a comment
JTCunning
left a comment
There was a problem hiding this comment.
Reacted with 👍/👎 for agreement.
Looks good, bonus points if this was ran in the same environment that caught the thread spawning debacle.
Generated by 🚫 danger |
|
I made those changes. I didn't test this using the Trifecta of Doom because I didn't do the research on how to build a Docker image off of |
This should be unnecessary after GH-5499.
This is essentially a revert of ac5dfeb.