feat(onboarding): Add profiling to platform node - #55530
Conversation
github-actions
Bot
added
the
Scope: Frontend
There was a problem hiding this comment.
I extracted the common logic for the node platforms into this file as it would be a lot of logic duplication when I continue to add the product selector to the others.
| params.push( | ||
| `// Set sampling rate for profiling - this is relative to tracesSampleRate` | ||
| ); | ||
| params.push( | ||
| `profilesSampleRate: 1.0, // Capture 100% of the transactions, reduce in production!` | ||
| ); |
There was a problem hiding this comment.
Why do we use single-line inserts instead of backticks with multiline content?
Is it better for indentation formatting?
There was a problem hiding this comment.
Yes, this way we leave the indentation up to the single platform files.
Imho, indentation should not be a concern of those utils as they are not aware of the full code snippet context.
|
@Lms24 since we talked about the content: |
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for applying my feedback around CJS/ESM. Love the dynamic getting started docs!
Had one minor comment. 
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
3 participants
Add profiling product selection to platform node.
Closes #55441