Skip to content

perf(issues): Move annotated text useProjects into subcomponent#59246

Merged
scttcper merged 1 commit into
masterfrom
scttcper/annotated-text-perf
Nov 2, 2023
Merged

perf(issues): Move annotated text useProjects into subcomponent#59246
scttcper merged 1 commit into
masterfrom
scttcper/annotated-text-perf

Conversation

@scttcper

@scttcper scttcper commented Nov 1, 2023

Copy link
Copy Markdown
Member

We only use projects/organization when displaying "[Filtered]", the rest do not need it. By moving it lower we can reduce the number of useProjects on the page (assuming not all values are filtered).

An update to the store causes all the components listening to useProjects to update which on some issue details pages could be 300-500 of these AnnotatedText components

image

We only use projects/organization when displaying [Filtered], the rest are static. By moving it lower we can reduce the number of useProjects on the page (assuming not all values are filtered).
@scttcper scttcper requested a review from a team November 1, 2023 23:20
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 1, 2023
@scttcper scttcper requested a review from JonasBa November 1, 2023 23:22

@malwilley malwilley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@scttcper scttcper changed the title perf(issues): Move annotated text useProjects inside subcomponent perf(issues): Move annotated text useProjects into subcomponent Nov 2, 2023
@scttcper scttcper merged commit 9d70d16 into master Nov 2, 2023
@scttcper scttcper deleted the scttcper/annotated-text-perf branch November 2, 2023 00:06
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants