ref(grouping): Add SDK name as a tag on event_manager metrics

[vartec]

Adding SDK tag to event_manager metrics.

Implements: #59053

[vartec]

^^ auto-formatting

[lobsterkatie]

Technically, to match our conventions, I'd do ref(grouping): Add SDK name..., but otherwise, LGTM!

Can you please update the relevant tests, also? This may not find all of them, but a good place to start is to search for mock_metrics_incr.

[lobsterkatie]

Looking at this more closely (which I should have done the first time, sorry), a few small things:

• We use present tense rather than gerund in our PR titles/commit messages ("add" rather than "adding").

• There's one spot, called out below, where I don't think we need to add an SDK tag.

• I think it's worth deciding the scope of this change and either revising the PR title or pulling most of your changes into a separate PR. Of the metrics you've modified here, only the one in _calculate_event_grouping and the one labeled grouping.in_app_frame_mix are actually grouping metrics. (You'd be forgiven for thinking that the one in _calculate_span_grouping is also about grouping, but when we say "grouping," what we really mean is specifically event grouping.) So I'd either a) pull "grouping" out of the PR title, and make it just about event_manager metrics, or b) restrict it just to grouping metrics.

• In either case, I'd also add the tags in the following spots:

  • The event_manager.apply_server_fingerprinting metric.
  • The event_manager.background_grouping metric. For this one, you'll need to switch from the decorator to a context manager inside the function calling metrics.timer (which is what metrics.wraps does internaly).
  • The metric_tags passed to save_error_events inside of save.

[codecov]

Codecov Report

Merging #59379 (0c0a135) into master (c2e0590) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #59379      +/-   ##
==========================================
- Coverage   80.77%   80.77%   -0.01%     
==========================================
  Files        5164     5164              
  Lines      225813   225813              
  Branches    37995    37995              
==========================================
- Hits       182403   182401       -2     
- Misses      37883    37884       +1     
- Partials     5527     5528       +1     

see 9 files with indirect coverage changes

[lobsterkatie]

Good catch on the save_event.calculate_event_grouping metric!

[getsentry-bot]

PR reverted: 90781a3

[lobsterkatie]

We reverted this because it was blowing up the number of tags we're keeping track of in DD. We're going to look into doing some normalization to reduce the number of values.