ref(grouping): Add normalized SDK name as a tag on event_manager metrics#59572
Merged
Conversation
Adding SDK tag to event_manager metrics. Implements: #59053
Co-authored-by: Katie Byers <katie.byers@sentry.io>
github-actions
Bot
added
the
Scope: Backend
Contributor
Author
|
I'll re-base once #59504 lands, making it much smaller PR |
Codecov Report
@@ Coverage Diff @@
## master #59572 +/- ##
=======================================
Coverage 80.76% 80.76%
=======================================
Files 5173 5173
Lines 226920 226920
Branches 38155 38155
=======================================
+ Hits 183268 183276 +8
+ Misses 38097 38092 -5
+ Partials 5555 5552 -3 |
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Contributor
|
PR reverted: b8c0b8a |
This was referenced Nov 9, 2023
vartec
pushed a commit
that referenced
this pull request
Nov 9, 2023
#59736) #59572 + fix for `TypeError` - validated that [new test](bb4771d) causes `TypeError` without the fix - validated that the fix works even without `try/except` - added generic try/except as defense in depth [Diff for just the fix + test](https://github.com/getsentry/sentry/pull/59736/files/38f868af62fb13a88993e83a2048852309c0964c..bb4771d6f1330375080d4d4526599d780b0293ae) --------- Co-authored-by: Katie Byers <katie.byers@sentry.io> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-applies previously reverted #59379 combining it with #59504 to normalize SDK tags reducing their cardinality.
Implements: #59053