Skip to content

fix(projects): Disable release health setup buttons when platform is not supported#72567

Merged
malwilley merged 2 commits into
masterfrom
malwilley/fix/release-health-setup-buttons
Jun 13, 2024
Merged

fix(projects): Disable release health setup buttons when platform is not supported#72567
malwilley merged 2 commits into
masterfrom
malwilley/fix/release-health-setup-buttons

Conversation

@malwilley

Copy link
Copy Markdown
Member

Fixes #72560

Consistently displays a disabled setup button when the project platform does not support release health. Previously, we only did this on the project list page but not on the project details page.

Before:

CleanShot 2024-06-11 at 15 42 39

CleanShot 2024-06-11 at 15 43 07

After:

CleanShot 2024-06-11 at 15 42 48

CleanShot 2024-06-11 at 15 43 00

@malwilley malwilley requested a review from a team as a code owner June 11, 2024 22:44
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 11, 2024
@malwilley malwilley force-pushed the malwilley/fix/release-health-setup-buttons branch from d1460b1 to 122e769 Compare June 11, 2024 22:51
@codecov

codecov Bot commented Jun 11, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (194c8a4) to head (28622f2).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72567       +/-   ##
===========================================
+ Coverage   56.95%   78.02%   +21.06%     
===========================================
  Files        6585     6596       +11     
  Lines      293603   293978      +375     
  Branches    50671    50726       +55     
===========================================
+ Hits       167223   229363    +62140     
+ Misses     121662    58361    -63301     
- Partials     4718     6254     +1536     
Files Coverage Δ
...l/missingFeatureButtons/missingReleasesButtons.tsx 63.63% <100.00%> (+3.63%) ⬆️
static/app/views/projectDetail/projectDetail.tsx 56.52% <ø> (ø)
...jectDetail/projectScoreCards/projectScoreCards.tsx 100.00% <ø> (ø)
...il/projectScoreCards/projectStabilityScoreCard.tsx 83.33% <ø> (ø)
static/app/views/projectsDashboard/projectCard.tsx 81.81% <ø> (-1.11%) ⬇️
.../app/views/projectDetail/projectLatestReleases.tsx 87.50% <80.00%> (ø)

... and 2010 files with indirect coverage changes

@malwilley malwilley merged commit c1e4359 into master Jun 13, 2024
@malwilley malwilley deleted the malwilley/fix/release-health-setup-buttons branch June 13, 2024 17:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Projects that should not have release sessions data should hide button to setup sessions

3 participants