ref(crons): Change copy for over quota processing error#72707
Merged
davidenwang merged 1 commit intoJun 13, 2024
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Jun 13, 2024
davidenwang
deleted the
davidenwang/copy-change-processing-error-over-quota
branch
Bundle ReportChanges will decrease total bundle size by 75 bytes ⬇️
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After more auditing I feel like this is the most appropriate copy for the
MONITOR_OVER_QUOTAprocessing error.This copy is now very similar to the
MONITOR_DISABLEDerror. This is because in getsentry we always check to see if we should ingest a check-in based on if there is a seat assigned, before checking if the monitor is disabled. However, when a user disables a monitor the seat is removed.This means that if a user manually disables a monitor we will write
MONITOR_OVER_QUOTAerrors, rather thanMONITOR_DISABLEDerrors if they are a saas customer. In this case, the best action we can give to the user is increase on-demand if needed, and then try enabling the monitor.Also slightly changed the title for the upsert event to make it more clear.