fix(prism): Remove unnecessary vertical-align: middle style#75313
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
michellewzhang
approved these changes
Jul 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75313 +/- ##
==========================================
- Coverage 78.21% 78.21% -0.01%
==========================================
Files 6775 6779 +4
Lines 302013 302025 +12
Branches 51963 51963
==========================================
Hits 236217 236217
- Misses 59443 59455 +12
Partials 6353 6353
|
roaga
pushed a commit
that referenced
this pull request
Jul 31, 2024
The style adds unnecessary whitespace between lines and causes line highlighting to be misaligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This style was added here (by me), but it doesn't seem like it's needed any longer (and I can't remember why I originally added it 🤔).
The style adds unnecessary whitespace between lines and causes line highlighting to be misaligned (as attempted in #75294). If you compare the CodeSnippet stories at
/stories/?name=app/components/codeSnippet.stories.tsx, it looks the same but slightly more compact now.