feat(trace-explorer): Use new SearchQueryBuilder#75979
Merged
Zylphrex merged 2 commits intoAug 12, 2024
Merged
Conversation
This switches the trace explorer to use the new SearchQueryBuilder.
github-actions
Bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 24.43kB ⬆️
|
malwilley
reviewed
Aug 12, 2024
| }, [supportedTags]); | ||
|
|
||
| const filterKeySections = useMemo(() => { | ||
| return []; |
Member
There was a problem hiding this comment.
Should this be filled out? Categories would help the user find the right keys
Member
Author
There was a problem hiding this comment.
Yes, just starting without it and will fill it in in a followup
| const organization = useOrganization(); | ||
| const {selection} = usePageFilters(); | ||
|
|
||
| const placeholderText = useMemo(() => { |
Member
There was a problem hiding this comment.
nit: memo not necessary for string props
Member
Author
There was a problem hiding this comment.
will address in the follow up
malwilley
approved these changes
Aug 12, 2024
Zylphrex
deleted the
txiao/feat/use-new-search-query-builder-for-trace-explorer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the trace explorer to use the new SearchQueryBuilder.