style(settings): align checkbox with org name#76685
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Aug 28, 2024
evanpurkhiser
left a comment
evanpurkhiser
left a comment
Member
There was a problem hiding this comment.
Do we have a more appropriate component we can use here even?
Contributor
Author
hm we might be able to use the |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
scttcper
reviewed
Aug 28, 2024
| onChange={evt => handleChange(organization, singleOwner, evt)} | ||
| size="sm" | ||
| /> | ||
| {organization.slug} |
Member
There was a problem hiding this comment.
i think this would mean that you can no longer click on the org slug to check the box? Wrapping in a label element might fix this
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
ah good catch, just fixed
scttcper
approved these changes
Aug 28, 2024
ArthurKnaus
pushed a commit
that referenced
this pull request
Aug 29, 2024
before <img width="614" alt="SCR-20240828-kbvc" src="https://github.com/user-attachments/assets/324b37fa-c774-419c-9281-06f98ae1a3c1"> https://github.com/user-attachments/assets/354385f0-5e56-45e7-a9d5-a44bd9473a13 after https://github.com/user-attachments/assets/08ade250-6130-4c39-a956-85dac9fd6a88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before
Screen.Recording.2024-08-28.at.11.26.44.AM.mov
after
Screen.Recording.2024-08-28.at.11.26.01.AM.mov