Skip to content

ref(crons): Handle errors when dispatching send_incident_occurrence#80906

Merged
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-crons-handle-errors-when-dispatching-send-incident-occurrence
Nov 18, 2024
Merged

ref(crons): Handle errors when dispatching send_incident_occurrence#80906
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-crons-handle-errors-when-dispatching-send-incident-occurrence

Conversation

@evanpurkhiser

Copy link
Copy Markdown
Member

This helps us handle things like SENTRY-3J3R

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner November 18, 2024 16:47
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 18, 2024
send_incident_occurrence(failed_checkin, previous_checkins, incident, received)
try:
send_incident_occurrence(failed_checkin, previous_checkins, incident, received)
except Exception:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we catch something so broad? would we want to DLQ instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add a note to follow up for this

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) November 18, 2024 16:52
@evanpurkhiser evanpurkhiser merged commit f167f36 into master Nov 18, 2024
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-handle-errors-when-dispatching-send-incident-occurrence branch November 18, 2024 17:22
@codecov

codecov Bot commented Nov 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...onitors/consumers/incident_occurrences_consumer.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #80906   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files        7211     7211           
  Lines      319731   319740    +9     
  Branches    44007    44008    +1     
=======================================
+ Hits       250746   250760   +14     
+ Misses      62600    62595    -5     
  Partials     6385     6385           

@sentry

sentry Bot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Environment.DoesNotExist: Environment matching query does not exist. sentry.monitors.models in get_environment View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants