ref(crons): Handle errors when dispatching send_incident_occurrence#80906
Merged
evanpurkhiser merged 1 commit intoNov 18, 2024
Conversation
This helps us handle things like [SENTRY-3J3R](https://sentry.sentry.io/issues/6073039699/)
JoshFerge
reviewed
Nov 18, 2024
| send_incident_occurrence(failed_checkin, previous_checkins, incident, received) | ||
| try: | ||
| send_incident_occurrence(failed_checkin, previous_checkins, incident, received) | ||
| except Exception: |
Member
There was a problem hiding this comment.
should we catch something so broad? would we want to DLQ instead?
Member
Author
There was a problem hiding this comment.
Let me add a note to follow up for this
JoshFerge
approved these changes
Nov 18, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80906 +/- ##
=======================================
Coverage 78.42% 78.42%
=======================================
Files 7211 7211
Lines 319731 319740 +9
Branches 44007 44008 +1
=======================================
+ Hits 250746 250760 +14
+ Misses 62600 62595 -5
Partials 6385 6385 |
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps us handle things like SENTRY-3J3R