Skip to content

feat(devservices): Add taskbroker to devservices, taskworker to devserver#82244

Merged
evanh merged 1 commit into
masterfrom
evanh/fix/add-taskbroker-new-devservices
Dec 19, 2024
Merged

feat(devservices): Add taskbroker to devservices, taskworker to devserver#82244
evanh merged 1 commit into
masterfrom
evanh/fix/add-taskbroker-new-devservices

Conversation

@evanh
Copy link
Copy Markdown
Member

@evanh evanh commented Dec 17, 2024

This PR adds the taskbroker to the new devservices (it has been added to old devservices in a
separate PR) and also adds an option to devserver to start the taskworker daemon.

PR for old devservices: #82244

…rver

This PR adds the taskbroker to the new devservices (it has been added to old devservices in a
separate PR) and also adds an option to devserver to start the taskworker daemon.
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Dec 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@evanh
Copy link
Copy Markdown
Member Author

evanh commented Dec 17, 2024

Testing devserver locally:

ᐅ sentry devserver --taskworker
INFO:The Sentry runner will report development issues to Sentry.io. Use SENTRY_DEVENV_NO_REPORT to avoid reporting issues.
18:39:23 system     | webpack started (pid=13838)
18:39:23 system     | taskworker started (pid=13836)
18:39:23 system     | server started (pid=13837)
18:39:24 taskworker | INFO:The Sentry runner will report development issues to Sentry.io. Use 
...
18:39:29 taskworker | 18:39:29 [INFO] sentry.taskworker.worker: get_task failed. Retrying in 1 second
18:39:32 taskworker | 18:39:32 [INFO] sentry.taskworker.worker: get_task failed. Retrying in 1 second

The get_task call fails because of the bug preventing the taskbroker kafka topic from being created.

Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devserver daemon and cli option look good to me.

Copy link
Copy Markdown
Contributor

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too.

The get_task call fails because of the bug preventing the taskbroker kafka topic from being created.

On this, devserver needs to run with either --workers or --ingest for now to create the topics. Nonideal but it's now an item we're looking at

@evanh
Copy link
Copy Markdown
Member Author

evanh commented Dec 19, 2024

With this change now in taskbroker, the bug with kafka is fixed. I tested this all locally and now when running devservices up --mode taskbroker, the taskbroker will start and create the topic automatically if it is missing.

@evanh evanh merged commit 7f422fe into master Dec 19, 2024
@evanh evanh deleted the evanh/fix/add-taskbroker-new-devservices branch December 19, 2024 19:22
andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
…rver (#82244)

This PR adds the taskbroker to the new devservices (it has been added to
old devservices in a
separate PR) and also adds an option to devserver to start the
taskworker daemon.

PR for old devservices: #82244
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants