fix(migrations): Remove onerous snapshot tests #83140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
requested review from
a team,
asottile-sentry,
evanpurkhiser and
saponifi3d
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83140 +/- ##
==========================================
- Coverage 87.60% 87.59% -0.02%
==========================================
Files 9461 9461
Lines 536643 536554 -89
Branches 21097 21097
==========================================
- Hits 470142 469988 -154
- Misses 66142 66207 +65
Partials 359 359 |
saponifi3d
approved these changes
Jan 8, 2025
Contributor
There was a problem hiding this comment.
🙏 may want to have someone with more context also review, but lgtm. thanks for making migrations easier.
(test failures are just to remove the import for the SANITIZATION_TESTED set though, maybe more updates in https://github.com/getsentry/sentry/blob/master/tests/sentry/backup/test_coverage.py ?)
hubertdeng123
approved these changes
Jan 9, 2025
Member
hubertdeng123
left a comment
hubertdeng123
left a comment
There was a problem hiding this comment.
Given that the owner of these tests is now no longer with us, and since they haven't caught anything useful this seems fine to do
This removes tests that generate snapshots and fail whenever we add in new models. I don't think these tests have caught anything useful recently, and they cause a lot of noise and frustration when creating models. After this, we'll still need to run `bin/generate-model-dependency-fixtures`, but not the snapshot tests
wedamija
force-pushed
the
danf/migrations-remove-snapshot-tests
branch
from
0042148 to
8fd78f9
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
This removes tests that generate snapshots and fail whenever we add in new models. I don't think these tests have caught anything useful recently, and they cause a lot of noise and frustration when creating models. After this, we'll still need to run `bin/generate-model-dependency-fixtures`, but not the snapshot tests <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes tests that generate snapshots and fail whenever we add in new models. I don't think these tests have caught anything useful recently, and they cause a lot of noise and frustration when creating models.
After this, we'll still need to run
bin/generate-model-dependency-fixtures, but not the snapshot tests