ref: remove dep management from useHotkeys#85236
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the dep management from useHotkeys as it does not enforce or warn about hook dependencies, making it prone to errors.
I have tried to add this hook to react hook exhaustive deps first as opposed to removing dep (something we do for useMemoWithPrevious for example) , to see if we can get it to properly warn on wrong dependencies, but the linter trips on the inline function callback definition inside the hotkey definition, and wrongly recommends passing a function to this hook (which the signature does not allow for).